Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adding test for enabling sync of non-existent resource #8875

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[tests-only][full-ci] adding test for enabling sync of non-existent resource #8875

merged 1 commit into from
Apr 22, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Apr 17, 2024 •
edited
Loading

Description

Writing test coverage for bug regarding enabling sync of a share which was tracked here: #8724

added scenario

  Scenario: try to enable share sync of non-existing resource

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1: locally
  • test case 2: CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Apr 17, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Apr 17, 2024
Open
34 tasks
@saw-jan saw-jan mentioned this pull request Apr 17, 2024
Closed
23 tasks
@nirajacharya2 nirajacharya2 force-pushed the issue-8724-coverage branch 2 times, most recently from 03e51ee to 7642c3d Compare April 18, 2024 09:34
@nirajacharya2 nirajacharya2 marked this pull request as ready for review April 18, 2024 09:34
@nirajacharya2 nirajacharya2 force-pushed the issue-8724-coverage branch 3 times, most recently from fc5b4b2 to 6b89696 Compare April 19, 2024 03:06
@saw-jan saw-jan changed the title [tests-only][full-ci] adding test for enabling sync with invalid remote item id [tests-only][full-ci] adding test for enabling sync of non-existing resource Apr 19, 2024
@saw-jan
Copy link
Member

saw-jan commented Apr 19, 2024

Please, rebase the PR

@nirajacharya2 nirajacharya2 force-pushed the issue-8724-coverage branch 2 times, most recently from 66021d6 to da77428 Compare April 22, 2024 04:03
@saw-jan
Copy link
Member

saw-jan commented Apr 22, 2024

Please, rebase the PR

❗

phil-davis
phil-davis reviewed Apr 22, 2024
View reviewed changes
tests/acceptance/features/apiSharingNg/listPermissions.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharingNg/listPermissions.feature Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/SharingNgContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/SharingNgContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/SharingNgContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/SharingNgContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharingNg/enableDisableShareSync.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharingNg/enableDisableShareSync.feature Outdated Show resolved Hide resolved
@phil-davis phil-davis changed the title [tests-only][full-ci] adding test for enabling sync of non-existing resource [tests-only][full-ci] adding test for enabling sync of non-existent resource Apr 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

phil-davis
phil-davis approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - other people please also review

@nirajacharya2 nirajacharya2 requested a review from grgprarup April 22, 2024 10:22
grgprarup
grgprarup approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grgprarup grgprarup merged commit d0dd6c8 into master Apr 22, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-8724-coverage branch April 22, 2024 11:18
ownclouders pushed a commit that referenced this pull request Apr 22, 2024
@grgprarup
Merge pull request #8875 from owncloud/issue-8724-coverage
f45b7e4 
[tests-only][full-ci] adding test for enabling sync of non-existent resource
@grgprarup grgprarup mentioned this pull request Jun 11, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup approved these changes

@phil-davis phil-davis phil-davis approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@nabim777 nabim777 Awaiting requested review from nabim777

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirajacharya2 @saw-jan @phil-davis @grgprarup @nabim777 @S-Panta